make #[track_caller] actually do stuff in Steal::borrow
#89237
Conversation
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
BoxyUwU
force-pushed
the
trackersMcCaller
branch
from
ddd34b0
to
f1e71a5
Compare
|
This might be sensitive for incremental: @bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit f1e71a5 with merge 26605d2c2c54440efef2a4936728fe5404196afa... |
|
☀️ Try build successful - checks-actions |
|
Queued 26605d2c2c54440efef2a4936728fe5404196afa with parent 7342213, future comparison URL. |
|
Finished benchmarking commit (26605d2c2c54440efef2a4936728fe5404196afa): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
@bors r=eddyb |
|
📌 Commit f1e71a5 has been approved by |
bors
added
S-waiting-on-bors
|
Better add test to track error message :-) |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (218a96c): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
makes this ICE message useful:
thread 'rustc' panicked at 'attempted to read from stolen value', /rustc/ac2d9fc509e36d1b32513744adf58c34bcc4f43c\compiler\rustc_data_structures\src\steal.rs:37:21